Issue 1311233003: Add chrome.virtualKeyboardPrivate.setHotrodKeyboard API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311233003: Add chrome.virtualKeyboardPrivate.setHotrodKeyboard API

Created:
5 years, 4 months ago by bshe

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add chrome.virtualKeyboardPrivate.setHotrodKeyboard API Hotrod wants to have customized VK layout. But virtual keyboard currently doesnt have a way to know if the focus is inside hotrod app. So we create a chrome.virtualKeyboardPrivate.setHotrodKeyboard for hotrod apps to use. On hotrod startup, it will call this API which set a boolean in Chrome. Afterwards, chrome.virtualKeyboardPrivate.getKeyboardConfig will return the correct state of hotrod keyboard in a 'hotrodmode' field. BUG=

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -1 line)			Patch
M	chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc	View	3 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	extensions/browser/extension_function_histogram_value.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/common/api/virtual_keyboard_private.json	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/keyboard/keyboard_util.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/keyboard/keyboard_util.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 49863002 Patch 1