Source/modules/screen_orientation/ScreenOrientation.h - Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.h

Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix ScreenOrientation + test window.open. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/screen_orientation/ScreenOrientation.h

diff --git a/Source/modules/screen_orientation/ScreenOrientation.h b/Source/modules/screen_orientation/ScreenOrientation.h

index 5f9d0a83848ed9316d449972dce7c6778afa4572..ff5a85f657c4f7ed402d025143a03af0ac38f008 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.h

+++ b/Source/modules/screen_orientation/ScreenOrientation.h

@@ -38,7 +38,7 @@ private:

void orientationLockTimerFired(Timer<ScreenOrientation>*);

static const char* supplementName();

- Document& document() const;

+ Document* document() const;

Timer<ScreenOrientation> m_orientationLockTimer;

blink::WebScreenOrientations m_lockedOrientations;