Source/modules/screen_orientation/ScreenOrientation.h - Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/screen_orientation/ScreenOrientation.h

Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix ScreenOrientation + test window.open. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/frame/DOMWindow.cpp ('K') | « Source/core/timing/Performance.cpp ('k') | Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ScreenOrientation_h	5 #ifndef ScreenOrientation_h

6 #define ScreenOrientation_h	6 #define ScreenOrientation_h

7	7

8 #include "core/events/EventTarget.h"	8 #include "core/events/EventTarget.h"

9 #include "core/frame/DOMWindowProperty.h"	9 #include "core/frame/DOMWindowProperty.h"

10 #include "platform/Supplementable.h"	10 #include "platform/Supplementable.h"

(...skipping 20 matching lines...) Expand all Loading...
31 static bool lockOrientation(Screen&, const AtomicString& orientation);	31 static bool lockOrientation(Screen&, const AtomicString& orientation);

32 static void unlockOrientation(Screen&);	32 static void unlockOrientation(Screen&);

33	33

34 private:	34 private:

35 explicit ScreenOrientation(Screen&);	35 explicit ScreenOrientation(Screen&);

36	36

37 void lockOrientationAsync(blink::WebScreenOrientations);	37 void lockOrientationAsync(blink::WebScreenOrientations);

38 void orientationLockTimerFired(Timer<ScreenOrientation>*);	38 void orientationLockTimerFired(Timer<ScreenOrientation>*);

39	39

40 static const char* supplementName();	40 static const char* supplementName();

41 Document& document() const;	41 Document* document() const;

42	42

43 Timer<ScreenOrientation> m_orientationLockTimer;	43 Timer<ScreenOrientation> m_orientationLockTimer;

44 blink::WebScreenOrientations m_lockedOrientations;	44 blink::WebScreenOrientations m_lockedOrientations;

45 };	45 };

46	46

47 } // namespace WebCore	47 } // namespace WebCore

48	48

49 #endif // ScreenOrientation_h	49 #endif // ScreenOrientation_h

OLD	NEW