Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 13111002: gpu: Fix in-process implementation of glGetShaderPrecisionFormat (Closed)

Created:
7 years, 9 months ago by brianderson
Modified:
7 years, 8 months ago
Reviewers:
greggman
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium, Ken Russell (switch to Gerrit)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

gpu: Fix in-process implementation of glGetShaderPrecisionFormat This copies the workaround used in the command buffer implementation to the in-process implementation. A common function isn't used since the in-process version will likely go away soon and using a common version requires twisting the code a bit. BUG=178327 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191530

Patch Set 1 #

Patch Set 2 : Fix link errors on mac/win #

Patch Set 3 : Remove accidental whitespace #

Patch Set 4 : copy workaround instead of sharing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 2 3 1 chunk +37 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brianderson
Not sure if gl_implementation.cc is the best place to put the common implementation of GetShaderPrecisionFormatImpl. ...
7 years, 9 months ago (2013-03-27 02:36:22 UTC) #1
greggman
Hmmm, off the top of my head it seems like maybe we should duplicate the ...
7 years, 8 months ago (2013-03-29 17:18:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/13111002/34001
7 years, 8 months ago (2013-03-29 17:47:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/13111002/34001
7 years, 8 months ago (2013-03-30 17:01:23 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 17:50:25 UTC) #5
Message was sent while issue was closed.
Change committed as 191530

Powered by Google App Engine
This is Rietveld 408576698