Issue 1311043005: Some commit messages contain unicode characters, making them strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311043005: Some commit messages contain unicode characters, making them strings. (Closed)

Created:
5 years, 3 months ago by RobertoCN

Modified:
5 years, 3 months ago

Reviewers:
prasadv

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@hax

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

Some commit messages contain unicode characters, making them strings. Note the commit message in crrev.com/4938031b935dde126f2a48140a95a48fd7b5e0fc for example. R=prasadv BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296460

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	scripts/slave/recipe_modules/auto_bisect/bisect_results.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311043005/1

5 years, 3 months ago (2015-08-27 22:09:56 UTC) #3

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 22:12:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296460

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages