scripts/slave/recipe_modules/auto_bisect/bisect_results.py - Issue 1311043005: Some commit messages contain unicode characters, making them strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisect_results.py

Issue 1311043005: Some commit messages contain unicode characters, making them strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@hax

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/bisect_results.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/bisect_results.py b/scripts/slave/recipe_modules/auto_bisect/bisect_results.py

index ffafc55df19ba70a945fcd5b94e1f037c28ab16f..e4970d7babdcec1aa9cc89f800f7dcd46700c18e 100644

--- a/scripts/slave/recipe_modules/auto_bisect/bisect_results.py

+++ b/scripts/slave/recipe_modules/auto_bisect/bisect_results.py

@@ -140,7 +140,7 @@ class BisectResults(object):

'cl': self.culprit_cl_hash

}

body += self._compose_revisions_table()

- return body

+ return body.encode('ascii','replace')

def _make_footer(self):

return _RESULTS_THANKYOU

« no previous file with comments | « no previous file | no next file » | no next file with comments »