Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: runtime/vm/instructions_mips.cc

Issue 131103025: Fixes ABI bug in MIPS. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_mips.cc
===================================================================
--- runtime/vm/instructions_mips.cc (revision 32146)
+++ runtime/vm/instructions_mips.cc (working copy)
@@ -21,15 +21,15 @@
args_desc_(Array::Handle()),
ic_data_(ICData::Handle()) {
ASSERT(code.ContainsInstructionAt(pc));
- // Last instruction: jalr RA, TMP(=R1).
- ASSERT(*(reinterpret_cast<uword*>(end_) - 2) == 0x0020f809);
+ // Last instruction: jalr RA, T9(=R25).
+ ASSERT(*(reinterpret_cast<uword*>(end_) - 2) == 0x0320f809);
Register reg;
// The end of the pattern is the instruction after the delay slot of the jalr.
ic_data_load_end_ =
InstructionPattern::DecodeLoadWordFromPool(end_ - (2 * Instr::kInstrSize),
&reg,
&target_address_pool_index_);
- ASSERT(reg == TMP);
+ ASSERT(reg == T9);
}
@@ -180,9 +180,9 @@
uint16_t target_lo = target_address & 0xffff;
uint16_t target_hi = target_address >> 16;
- lui->SetImmInstrBits(LUI, ZR, TMP, target_hi);
- ori->SetImmInstrBits(ORI, TMP, TMP, target_lo);
- jr->SetSpecialInstrBits(JALR, TMP, ZR, RA);
+ lui->SetImmInstrBits(LUI, ZR, T9, target_hi);
+ ori->SetImmInstrBits(ORI, T9, T9, target_lo);
+ jr->SetSpecialInstrBits(JALR, T9, ZR, RA);
nop->SetInstructionBits(Instr::kNopInstruction);
ASSERT(kFixedLengthInBytes == 4 * Instr::kInstrSize);
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698