ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc - Issue 1311013002: [Ozone] Fix SingleOnTop issue by checking if the quad is clipped.

Unified Diff: ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

Issue 1311013002: [Ozone] Fix SingleOnTop issue by checking if the quad is clipped. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/output/overlay_strategy_common.cc ('K') | « content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc ('k') | ui/ozone/public/overlay_candidates_ozone.h » ('j') | ui/ozone/public/overlay_candidates_ozone.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

diff --git a/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc b/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

index 52e31b158230b4d40f17c75d833ebff7b9afd1b7..9ecac23606f7c8452b652960d8886e364c5c9938 100644

--- a/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

+++ b/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

@@ -79,6 +79,10 @@ void DrmOverlayCandidatesHost::CheckSingleOverlay(

return;

if (overlay->transform == gfx::OVERLAY_TRANSFORM_INVALID)

return;

+ if (!(overlay->is_clipped &&

danakj 2015/08/31 22:11:47 this doesn't quite look right? you want to abort

danakj 2015/08/31 22:24:36 btw, where are the unit tests for this? they would

william.xie1 2015/09/01 03:40:33 Done.

+ overlay->clip_rect.Contains(

+ gfx::ToEnclosingRect(overlay->geometry_rect))))

danakj 2015/08/31 22:11:47 if you make the geometry_rect a gfx::Rect you don'

william.xie1 2015/09/01 03:40:33 Done.

+ return;

OverlayCheck_Params lookup(*overlay);

auto iter = cache_.Get(lookup);