[Ozone] Fix SingleOnTop issue by checking if the quad is clipped.

ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/host/drm_overlay_candidates_host.h"
 
 #include <algorithm>
 
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/ozone/common/gpu/ozone_gpu_messages.h"
@@ skipping 61 matching lines @@
     overlay = first;
   } else {
     return;
   }
   // 0.01 constant chosen to match DCHECKs in gfx::ToNearestRect and avoid
   // that code asserting on quads that we accept.
   if (!gfx::IsNearestRectWithinDistance(overlay->display_rect, 0.01f))
     return;
   if (overlay->transform == gfx::OVERLAY_TRANSFORM_INVALID)
     return;
+  if (!(overlay->is_clipped &&

[danakj, 2015/08/31 22:11:47]

this doesn't quite look right?

you want to abort if the quad is clipped and the cliprect doesn't contain the
geometry rect?

that would be if is_clipped && !Contains?

[danakj, 2015/08/31 22:24:36]

btw, where are the unit tests for this? they would catch logic mistakes.

[william.xie1, 2015/09/01 03:40:33]

Done.

[william.xie1, 2015/09/01 03:40:33]

Done.

[william.xie1, 2015/09/01 03:40:33]

Done.

+        overlay->clip_rect.Contains(
+            gfx::ToEnclosingRect(overlay->geometry_rect))))

[danakj, 2015/08/31 22:11:47]

if you make the geometry_rect a gfx::Rect you don't need the ToEnclosingRect
here.

[william.xie1, 2015/09/01 03:40:33]

Done.

[william.xie1, 2015/09/01 03:40:33]

Done.

[william.xie1, 2015/09/01 03:40:33]

Done.

+    return;
 
   OverlayCheck_Params lookup(*overlay);
   auto iter = cache_.Get(lookup);
   if (iter == cache_.end()) {
     cache_.Put(lookup, false);
     SendRequest(*candidates, lookup);
   } else {
     overlay->overlay_handled = iter->second;
   }
 }
@@ skipping 40 matching lines @@
   pending_checks_.pop_front();
 }
 
 void DrmOverlayCandidatesHost::ProcessResult(const OverlayCheck_Params& check,
                                              bool result) {
   if (result)
     cache_.Put(check, true);
 }
 
 }  // namespace ui