Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1310993004: Add atomic utilities: AtomicValue, AtomicEnumSet, and AtomicEnumFlag (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adds atomic utilities (based on raw atomic operations) for your convenience: {AtomicValue}: A simple integer value that can be atomically read/set/incremented. {AtomicEnumSet}: Similar to EnumSet this set basically represents an atomic bitfield based on enums. Atomic operations guarantee that setting one bit does not race with setting other bits. {AtomicEnumFlag}: A flag that is based on an enum that can be read and (attempted to be) changed atomically. BUG=chromium:524425 LOG=N Committed: https://crrev.com/47d42a9ac120080fbb7d48805780d5edf18a00d8 Cr-Commit-Position: refs/heads/master@{#30560}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add new file to buildsystem files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/atomic-utils.h View 1 1 chunk +135 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Lippautz
RFC We definitely have the need for some atomic primitives (values/counters, sets, flags) in heap/ ...
5 years, 3 months ago (2015-09-03 10:31:39 UTC) #2
Benedikt Meurer
LGTM, but please add a more descriptive CL message.
5 years, 3 months ago (2015-09-03 10:32:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310993004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310993004/40001
5 years, 3 months ago (2015-09-03 11:27:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 12:54:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 12:54:43 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47d42a9ac120080fbb7d48805780d5edf18a00d8
Cr-Commit-Position: refs/heads/master@{#30560}

Powered by Google App Engine
This is Rietveld 408576698