Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325173003: [heap] Make AlwaysAllocateScope thread-safe. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@concurrency-support
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Make AlwaysAlloceScope thread-safe. BUG=chromium:524425 LOG=N R=mstarzinger@chromium.org Committed: https://crrev.com/296db16e6fe33369100c6771e430b94568c6ab4a Cr-Commit-Position: refs/heads/master@{#30563}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/heap/heap.h View 1 2 3 chunks +5 lines, -5 lines 1 comment Download
M src/heap/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Lippautz
AlwaysAllocateScope is soon used from multiple threads. https://codereview.chromium.org/1325173003/diff/40001/src/heap/heap.h File src/heap/heap.h (left): https://codereview.chromium.org/1325173003/diff/40001/src/heap/heap.h#oldcode780 src/heap/heap.h:780: Address always_allocate_scope_depth_address() ...
5 years, 3 months ago (2015-09-03 13:10:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325173003/40001
5 years, 3 months ago (2015-09-03 13:11:05 UTC) #4
Michael Starzinger
LGTM. Just for posterity, because it took me a while to figure out this race: ...
5 years, 3 months ago (2015-09-03 13:30:04 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 13:40:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325173003/40001
5 years, 3 months ago (2015-09-03 13:54:38 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 13:56:42 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 13:57:05 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/296db16e6fe33369100c6771e430b94568c6ab4a
Cr-Commit-Position: refs/heads/master@{#30563}

Powered by Google App Engine
This is Rietveld 408576698