Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1310903006: Appurify bot: don't use flags that visualbench doesn't support (Closed)

Created:
5 years, 3 months ago by borenet
Modified:
5 years, 3 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Appurify bot: don't use flags that visualbench doesn't support Depends on https://codereview.chromium.org/1320423005/ BUG=skia:4277 Committed: https://skia.googlesource.com/skia/+/d34d94766d54e3a0f2864d285f6262ef66cd9028

Patch Set 1 #

Patch Set 2 : Also remove --config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M tools/buildbot_spec.json View 1 1 chunk +0 lines, -13 lines 0 comments Download
M tools/nanobench_flags.py View 1 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
borenet
5 years, 3 months ago (2015-09-02 16:58:35 UTC) #2
joshualitt
On 2015/09/02 16:58:35, borenet wrote: lgtm
5 years, 3 months ago (2015-09-03 19:19:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310903006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310903006/20001
5 years, 3 months ago (2015-09-03 19:23:34 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 19:31:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d34d94766d54e3a0f2864d285f6262ef66cd9028

Powered by Google App Engine
This is Rietveld 408576698