Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/nanobench_flags.py

Issue 1310903006: Appurify bot: don't use flags that visualbench doesn't support (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Also remove --config Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/nanobench_flags.py
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index 5b4a968ffd758e7f71171455a6cecf971160fba4..d8bfafca40672832364be8b33f7243e11ccde953 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -29,22 +29,24 @@ cov_start = lineno()+1 # We care about coverage starting just past this def.
def get_args(bot):
args = []
- args.extend(['--scales', '1.0', '1.1'])
+ if 'Appurify' not in bot:
+ args.extend(['--scales', '1.0', '1.1'])
if 'iOS' in bot:
args.extend(['--skps', 'ignore_skps'])
- config = ['565', '8888', 'gpu', 'nonrendering', 'angle', 'hwui']
- # The S4 crashes and the NP produces a long error stream when we run with
- # MSAA.
- if ('GalaxyS4' not in bot and
- 'NexusPlayer' not in bot):
- if 'Android' in bot:
- config.extend(['msaa4', 'nvprmsaa4'])
- else:
- config.extend(['msaa16', 'nvprmsaa16'])
- args.append('--config')
- args.extend(config)
+ if 'Appurify' not in bot:
+ config = ['565', '8888', 'gpu', 'nonrendering', 'angle', 'hwui']
+ # The S4 crashes and the NP produces a long error stream when we run with
+ # MSAA.
+ if ('GalaxyS4' not in bot and
+ 'NexusPlayer' not in bot):
+ if 'Android' in bot:
+ config.extend(['msaa4', 'nvprmsaa4'])
+ else:
+ config.extend(['msaa16', 'nvprmsaa16'])
+ args.append('--config')
+ args.extend(config)
if 'Valgrind' in bot:
# Don't care about Valgrind performance.
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698