Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h

Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix issues in patch set 2. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/llvm/Bitcode/NaCl/NaClReaderWriter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h
diff --git a/include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h b/include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h
index 058af99bb6c172b466fb3e6db2808df3d6003f5d..085d1d8864cd032c004ab562306ae481183cd194 100644
--- a/include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h
+++ b/include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h
@@ -150,7 +150,7 @@ protected:
// message to.
raw_ostream &Error() {
FoundErrors = true;
- return getDumpStream() << "Error: ";
+ return getDumpStream() << "error: ";
}
// Returns the lines containing the given Substring, from the string
@@ -274,10 +274,13 @@ public:
/// Runs function llvm::NaClParseBitcodeFile, and puts error messages
/// into DumpResults. Returns true if parse is successful.
- bool runTest(const uint64_t Munges[], size_t MungesSize, bool VerboseErrors);
+ /// TODO(kschimpf) Remove VerboseErrors, no longer useful.
+ bool runTest(const uint64_t Munges[], size_t MungesSize,
+ bool VerboseErrors = false);
// Same as above, but without any edits.
- bool runTest(bool VerboseErrors) {
+ /// TODO(kschimpf) Remove VerboseErrors, no longer useful.
+ bool runTest(bool VerboseErrors = false) {
uint64_t NoMunges[] = {0};
return runTest(NoMunges, 0, VerboseErrors);
}
« no previous file with comments | « no previous file | include/llvm/Bitcode/NaCl/NaClReaderWriter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698