Install notion of diagnostic handler into PNaCl bitcode readers.

include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h

 //===- NaClBitcodeMunge.h - Bitcode Munger ----------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // Test harness for generating a PNaCl bitcode memory buffer from
@@ skipping 132 matching lines @@
   SmallVector<char, 1024> MungedInputBuffer;
   /// The write flags to use when writing bitcode.
   NaClMungedBitcode::WriteFlags WriteFlags;
   // Flag to redirect dump stream if running death test.
   bool RunAsDeathTest;
 
   // Records that an error occurred, and returns stream to print error
   // message to.
   raw_ostream &Error() {
     FoundErrors = true;
-    return getDumpStream() << "Error: ";
+    return getDumpStream() << "error: ";
   }
 
   // Returns the lines containing the given Substring, from the string
   // getTestResults(). If MustBePrefix, then Substring must match at
   // the beginning of the line.
   std::string getLinesWithTextMatch(const std::string &Substring,
                                     bool MustBePrefix = false) const;
 
   // Returns the log stream to use. When running death tests, redirect output
   // to the error stream (rather than buffering in DumpStream), so that
@@ skipping 103 matching lines @@
 
 // Class to run tests for function NaClParseBitcodeFile.
 class NaClParseBitcodeMunger : public NaClBitcodeMunger {
 public:
   NaClParseBitcodeMunger(const uint64_t Records[], size_t RecordsSize,
                          uint64_t RecordTerminator)
       : NaClBitcodeMunger(Records, RecordsSize, RecordTerminator) {}
 
   /// Runs function llvm::NaClParseBitcodeFile, and puts error messages
   /// into DumpResults. Returns true if parse is successful.
-  bool runTest(const uint64_t Munges[], size_t MungesSize, bool VerboseErrors);
+  /// TODO(kschimpf) Remove VerboseErrors, no longer useful.
+  bool runTest(const uint64_t Munges[], size_t MungesSize,
+               bool VerboseErrors = false);
 
   // Same as above, but without any edits.
-  bool runTest(bool VerboseErrors) {
+  /// TODO(kschimpf) Remove VerboseErrors, no longer useful.
+  bool runTest(bool VerboseErrors = false) {
     uint64_t NoMunges[] = {0};
     return runTest(NoMunges, 0, VerboseErrors);
   }
 };
 
 // Class to run tests for NaClBitcodeCompressor.compress().
 class NaClCompressMunger : public NaClBitcodeMunger {
 public:
   NaClCompressMunger(const uint64_t Records[], size_t RecordsSize,
                      uint64_t RecordTerminator)
       : NaClBitcodeMunger(Records, RecordsSize, RecordTerminator) {}
 
   bool runTest(const uint64_t Munges[], size_t MungesSize);
 
   bool runTest() {
     uint64_t NoMunges[] = {0};
     return runTest(NoMunges, 0);
   }
 };
 
 } // end namespace llvm.
 
 #endif // LLVM_BITCODE_NACL_NACLBITCODEMUNGE_H