Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310863002: NTP4: Remove some dead code dealing with footer layout (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP4: Remove some dead code dealing with footer layout R=estade@chromium.org BUG=329637 TEST=clearer code Committed: https://crrev.com/e0e48bdf20670dd0532afc4ed636a5b05ded9b65 Cr-Commit-Position: refs/heads/master@{#344953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/browser/resources/ntp4/tile_page.js View 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Beam
5 years, 4 months ago (2015-08-22 00:24:39 UTC) #1
Evan Stade
lgtm
5 years, 4 months ago (2015-08-22 01:02:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310863002/1
5 years, 4 months ago (2015-08-22 01:14:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/23346)
5 years, 4 months ago (2015-08-22 01:41:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310863002/1
5 years, 4 months ago (2015-08-22 01:47:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-22 02:14:46 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 02:15:30 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e0e48bdf20670dd0532afc4ed636a5b05ded9b65
Cr-Commit-Position: refs/heads/master@{#344953}

Powered by Google App Engine
This is Rietveld 408576698