Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/resources/ntp4/tile_page.js

Issue 1310863002: NTP4: Remove some dead code dealing with footer layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/tile_page.js
diff --git a/chrome/browser/resources/ntp4/tile_page.js b/chrome/browser/resources/ntp4/tile_page.js
index bc77367282342f0811694ef1e2b0d9aae8640fb9..f20d0f36a28310a1b116b0a2f8646a5dc0b073cf 100644
--- a/chrome/browser/resources/ntp4/tile_page.js
+++ b/chrome/browser/resources/ntp4/tile_page.js
@@ -500,15 +500,6 @@ cr.define('ntp', function() {
},
/**
- * Returns any extra padding to insert to the bottom of a tile page. By
- * default there is none, but subclasses can override.
- * @type {number}
- */
- get extraBottomPadding() {
- return 0;
- },
-
- /**
* The notification content of this tile (if any, otherwise null).
* @type {!HTMLElement}
*/
@@ -1105,20 +1096,8 @@ cr.define('ntp', function() {
// the tiles, whichever is greater. It would be nicer if tilePage were
// a flex box, and the tile grid could be box-flex: 1, but this exposes a
// bug where repositioning tiles will cause the scroll position to reset.
- this.tileGrid_.style.minHeight = (this.clientHeight -
- this.tileGrid_.offsetTop - this.content_.offsetTop -
- this.extraBottomPadding -
- (this.footerNode_ ? this.footerNode_.clientHeight : 0)) + 'px';
- },
-
- /**
- * Places an element at the bottom of the content div. Used in bare-minimum
- * mode to hold #footer.
- * @param {HTMLElement} footerNode The node to append to content.
- */
- appendFooter: function(footerNode) {
- this.footerNode_ = footerNode;
- this.content_.appendChild(footerNode);
+ this.tileGrid_.style.minHeight = this.clientHeight -
+ this.tileGrid_.offsetTop - this.content_.offsetTop + 'px';
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698