Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310743006: Replace use of scoped_ptr with OwnPtr. (Closed)

Created:
5 years, 3 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
bajones
CC:
blink-reviews, blundell
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace use of scoped_ptr with OwnPtr. Use of the base namespace in Blink is not currently recommended. Fortunately WTF::OwnPtr is a drop-in replacement here. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
Spotted by blundell@: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/IIkOmt66zEc/wPB-tfhfKQAJ I don't see any reason to use scoped_ptr here, so let's ...
5 years, 3 months ago (2015-09-04 15:37:03 UTC) #2
bajones
On 2015/09/04 15:37:03, jbroman wrote: > Spotted by blundell@: > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/IIkOmt66zEc/wPB-tfhfKQAJ > > I don't ...
5 years, 3 months ago (2015-09-04 15:53:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310743006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310743006/1
5 years, 3 months ago (2015-09-04 16:04:46 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 16:44:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201802

Powered by Google App Engine
This is Rietveld 408576698