Consistently use LoFi for an entire page

chrome/renderer/page_load_histograms.cc

Index: chrome/renderer/page_load_histograms.cc
diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc
index 3d8bfe29d5646eb139035b924eef2f288202f87a..03d1b50d26ba62d78b0d0de8302834339999011c 100644
--- a/chrome/renderer/page_load_histograms.cc
+++ b/chrome/renderer/page_load_histograms.cc
@@ -915,12 +915,15 @@ void PageLoadHistograms::Dump(WebFrame* frame) {
 
   MaybeDumpFirstLayoutHistograms();
 
+  content::RenderFrame* render_frame =
+      content::RenderFrame::FromWebFrame(frame);
+
   // Metrics based on the timing information recorded for the Navigation Timing
   // API - http://www.w3.org/TR/navigation-timing/.
-  DumpHistograms(
-      frame->performance(), document_state, data_reduction_proxy_was_used,
-      false /* TODO: render_frame->IsLoFiOn() */, came_from_websearch,
-      websearch_chrome_joint_experiment_id, is_preview, scheme_type);
+  DumpHistograms(frame->performance(), document_state,
+                 data_reduction_proxy_was_used, render_frame->IsLoFiOn(),

[mmenke, 2015/09/29 16:35:57]

Suggest UsingLoFi (Or IsUsingLoFi), think that makes it clearer it's a per-frame
setting, and not some global setting.  Should also use a consistent name here
and in the browser-side files.

[megjablon, 2015/09/29 21:20:07]

I like this better. Done.

+                 came_from_websearch, websearch_chrome_joint_experiment_id,
+                 is_preview, scheme_type);
 
   // Old metrics based on the timing information stored in DocumentState. These
   // are deprecated and should go away.