Consistently use LoFi for an entire page

chrome/renderer/page_load_histograms.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_histograms.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 897 matching lines @@
   int websearch_chrome_joint_experiment_id = kNoExperiment;
   bool is_preview = false;
   if (came_from_websearch) {
     websearch_chrome_joint_experiment_id =
         GetQueryStringBasedExperiment(GURL(frame->document().referrer()));
     is_preview = ViaHeaderContains(frame, "1.1 Google Instant Proxy Preview");
   }
 
   MaybeDumpFirstLayoutHistograms();
 
+  content::RenderFrame* render_frame =
+      content::RenderFrame::FromWebFrame(frame);
+
   // Metrics based on the timing information recorded for the Navigation Timing
   // API - http://www.w3.org/TR/navigation-timing/.
-  DumpHistograms(
-      frame->performance(), document_state, data_reduction_proxy_was_used,
-      false /* TODO: render_frame->IsLoFiOn() */, came_from_websearch,
-      websearch_chrome_joint_experiment_id, is_preview, scheme_type);
+  DumpHistograms(frame->performance(), document_state,
+                 data_reduction_proxy_was_used, render_frame->IsLoFiOn(),

[mmenke, 2015/09/29 16:35:57]

Suggest UsingLoFi (Or IsUsingLoFi), think that makes it clearer it's a per-frame
setting, and not some global setting.  Should also use a consistent name here
and in the browser-side files.

[megjablon, 2015/09/29 21:20:07]

I like this better. Done.

+                 came_from_websearch, websearch_chrome_joint_experiment_id,
+                 is_preview, scheme_type);
 
   // Old metrics based on the timing information stored in DocumentState. These
   // are deprecated and should go away.
   DumpDeprecatedHistograms(frame->performance(), document_state,
                            data_reduction_proxy_was_used,
                            came_from_websearch,
                            websearch_chrome_joint_experiment_id,
                            is_preview,
                            scheme_type);
 
@@ skipping 98 matching lines @@
 
   DCHECK(document_state);
   DCHECK(ds);
   GURL url(ds->request().url());
   Time start = document_state->start_load_time();
   Time finish = document_state->finish_load_time();
   // TODO(mbelshe): should we log more stats?
   VLOG(1) << "PLT: " << (finish - start).InMilliseconds() << "ms "
           << url.spec();
 }