Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/renderer/page_load_histograms.h

Issue 1310743003: Consistently use LoFi for an entire page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_histograms.h
diff --git a/chrome/renderer/page_load_histograms.h b/chrome/renderer/page_load_histograms.h
index 39f8cc5a9cb8c75d3d70b7dbaa4f5d0c9c38cfc2..bc8beb2b18e414f8c4374d9758182849dfc2619e 100644
--- a/chrome/renderer/page_load_histograms.h
+++ b/chrome/renderer/page_load_histograms.h
@@ -24,11 +24,13 @@ class PageLoadHistograms : public content::RenderViewObserver {
private:
// RenderViewObserver implementation.
- void FrameWillClose(blink::WebFrame* frame) override;
- void ClosePage() override;
+ void FrameWillClose(blink::WebFrame* frame, bool lofi_used) override;
+ void ClosePage(bool lofi_used) override;
void DidUpdateLayout() override;
// Dump all page load histograms appropriate for the given frame.
+ // Dump page load histograms that report whether or not the frame request was
+ // for a Lo-Fi version of the resource with the given |lofi_used|.
//
// This method will only dump once-per-instance, so it is safe to call
// multiple times.
@@ -47,7 +49,7 @@ class PageLoadHistograms : public content::RenderViewObserver {
// redirect had been done (the user never requested the page)
// Also, it's possible to load a page without ever laying it out
// so first_paint and first_paint_after_load can be 0.
- void Dump(blink::WebFrame* frame);
+ void Dump(blink::WebFrame* frame, bool lofi_used);
bool ShouldDump(blink::WebFrame* frame);
void MaybeDumpFirstLayoutHistograms();

Powered by Google App Engine
This is Rietveld 408576698