Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/renderer/page_load_histograms.h

Issue 1310743003: Consistently use LoFi for an entire page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_ 5 #ifndef CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_
6 #define CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_ 6 #define CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "content/public/renderer/render_view_observer.h" 10 #include "content/public/renderer/render_view_observer.h"
11 11
12 namespace blink { 12 namespace blink {
13 class WebDataSource; 13 class WebDataSource;
14 } 14 }
15 15
16 namespace content { 16 namespace content {
17 class DocumentState; 17 class DocumentState;
18 } 18 }
19 19
20 class PageLoadHistograms : public content::RenderViewObserver { 20 class PageLoadHistograms : public content::RenderViewObserver {
21 public: 21 public:
22 explicit PageLoadHistograms(content::RenderView* render_view); 22 explicit PageLoadHistograms(content::RenderView* render_view);
23 ~PageLoadHistograms() override; 23 ~PageLoadHistograms() override;
24 24
25 private: 25 private:
26 // RenderViewObserver implementation. 26 // RenderViewObserver implementation.
27 void FrameWillClose(blink::WebFrame* frame) override; 27 void FrameWillClose(blink::WebFrame* frame, bool lofi_used) override;
28 void ClosePage() override; 28 void ClosePage(bool lofi_used) override;
29 void DidUpdateLayout() override; 29 void DidUpdateLayout() override;
30 30
31 // Dump all page load histograms appropriate for the given frame. 31 // Dump all page load histograms appropriate for the given frame.
32 // Dump page load histograms that report whether or not the frame request was
33 // for a Lo-Fi version of the resource with the given |lofi_used|.
32 // 34 //
33 // This method will only dump once-per-instance, so it is safe to call 35 // This method will only dump once-per-instance, so it is safe to call
34 // multiple times. 36 // multiple times.
35 // 37 //
36 // The time points we keep are 38 // The time points we keep are
37 // request: time document was requested by user 39 // request: time document was requested by user
38 // start: time load of document started 40 // start: time load of document started
39 // commit: time load of document started 41 // commit: time load of document started
40 // finish_document: main document loaded, before onload() 42 // finish_document: main document loaded, before onload()
41 // finish_all_loads: after onload() and all resources are loaded 43 // finish_all_loads: after onload() and all resources are loaded
42 // first_paint: first paint performed 44 // first_paint: first paint performed
43 // first_paint_after_load: first paint performed after load is finished 45 // first_paint_after_load: first paint performed after load is finished
44 // begin: request if it was user requested, start otherwise 46 // begin: request if it was user requested, start otherwise
45 // 47 //
46 // It's possible for the request time not to be set, if a client 48 // It's possible for the request time not to be set, if a client
47 // redirect had been done (the user never requested the page) 49 // redirect had been done (the user never requested the page)
48 // Also, it's possible to load a page without ever laying it out 50 // Also, it's possible to load a page without ever laying it out
49 // so first_paint and first_paint_after_load can be 0. 51 // so first_paint and first_paint_after_load can be 0.
50 void Dump(blink::WebFrame* frame); 52 void Dump(blink::WebFrame* frame, bool lofi_used);
51 53
52 bool ShouldDump(blink::WebFrame* frame); 54 bool ShouldDump(blink::WebFrame* frame);
53 void MaybeDumpFirstLayoutHistograms(); 55 void MaybeDumpFirstLayoutHistograms();
54 void LogPageLoadTime(const content::DocumentState* load_times, 56 void LogPageLoadTime(const content::DocumentState* load_times,
55 const blink::WebDataSource* ds) const; 57 const blink::WebDataSource* ds) const;
56 58
57 bool dumped_first_layout_histograms_; 59 bool dumped_first_layout_histograms_;
58 base::WeakPtrFactory<PageLoadHistograms> weak_factory_; 60 base::WeakPtrFactory<PageLoadHistograms> weak_factory_;
59 61
60 DISALLOW_COPY_AND_ASSIGN(PageLoadHistograms); 62 DISALLOW_COPY_AND_ASSIGN(PageLoadHistograms);
61 }; 63 };
62 64
63 #endif // CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_ 65 #endif // CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698