Consistently use LoFi for an entire page

content/public/renderer/render_view_observer.h

Index: content/public/renderer/render_view_observer.h
diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h
index 0fcf959c60696a9a08b0cf05f8998f55f91fdfc5..05b4098882ddb2a057d660c6783091ba80fa905c 100644
--- a/content/public/renderer/render_view_observer.h
+++ b/content/public/renderer/render_view_observer.h
@@ -53,7 +53,7 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
   virtual void FrameCreated(blink::WebLocalFrame* parent,
                             blink::WebFrame* frame) {}
   virtual void FrameDetached(blink::WebFrame* frame) {}
-  virtual void FrameWillClose(blink::WebFrame* frame) {}
+  virtual void FrameWillClose(blink::WebFrame* frame, bool lofi_used) {}

[davidben, 2015/08/27 18:53:50]

This is a rather specific parameter to plumb into so general of a hook. This
smells wrong. You should instead get the value out of the RenderFrame.

[megjablon, 2015/08/27 23:11:02]

Without PlageLoadHistograms being a subclass of RenderFrameObserver, we have to
pass this value in.

[davidben, 2015/08/31 23:43:24]

I'll defer to nasko, but I would think it's possible to get the RenderFrameHost
out of the WebFrame. Alternatively, it PageLoadHistograms is fairly small. Can
we convert that to RenderFrameHostObserver?

[megjablon, 2015/09/09 20:54:16]

Done.

   virtual void PrintPage(blink::WebLocalFrame* frame, bool user_initiated) {}
   virtual void FocusedNodeChanged(const blink::WebNode& node) {}
   virtual void DraggableRegionsChanged(blink::WebFrame* frame) {}
@@ -67,7 +67,7 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
 
   // These match incoming IPCs.
   virtual void Navigate(const GURL& url) {}
-  virtual void ClosePage() {}
+  virtual void ClosePage(bool lofi_used) {}

[davidben, 2015/08/27 18:53:50]

Ditto.

[megjablon, 2015/09/09 20:54:16]

Done.

 
   // This indicates that animations to scroll the focused element into view (if
   // any) have completed. May be called more than once for a single focus. Can