Consistently use LoFi for an entire page

content/public/renderer/render_view_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
@@ skipping 10 matching lines @@
 struct WebURLError;
 }
 
 namespace content {
 
 class RenderView;
 class RenderViewImpl;
 
 // Base class for objects that want to filter incoming IPCs, and also get
 // notified of changes to the frame.
 class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,

[davidben, 2015/08/27 18:53:50]

Isn't RenderViewObserver being deprecated? Why not RenderFrameObserver?

[megjablon, 2015/08/27 23:11:02]

PageLoadHistograms is derived from RenderViewObserver where we report Lo-Fi
specific PLT histograms.

                                           public IPC::Sender {
  public:
   // By default, observers will be deleted when the RenderView goes away.  If
   // they want to outlive it, they can override this function.
   virtual void OnDestruct();
 
   // These match the WebKit API notifications
   virtual void DidStartLoading() {}
   virtual void DidStopLoading() {}
   virtual void DidFinishDocumentLoad(blink::WebLocalFrame* frame) {}
   virtual void DidFailLoad(blink::WebLocalFrame* frame,
                            const blink::WebURLError& error) {}
   virtual void DidFinishLoad(blink::WebLocalFrame* frame) {}
   virtual void DidStartProvisionalLoad(blink::WebLocalFrame* frame) {}
   virtual void DidFailProvisionalLoad(blink::WebLocalFrame* frame,
                                       const blink::WebURLError& error) {}
   virtual void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,
                                         bool is_new_navigation) {}
   virtual void DidCreateNewDocument(blink::WebLocalFrame* frame) {}
   virtual void DidClearWindowObject(blink::WebLocalFrame* frame) {}
   virtual void DidCreateDocumentElement(blink::WebLocalFrame* frame) {}
   virtual void FrameCreated(blink::WebLocalFrame* parent,
                             blink::WebFrame* frame) {}
   virtual void FrameDetached(blink::WebFrame* frame) {}
-  virtual void FrameWillClose(blink::WebFrame* frame) {}
+  virtual void FrameWillClose(blink::WebFrame* frame, bool lofi_used) {}

[davidben, 2015/08/27 18:53:50]

This is a rather specific parameter to plumb into so general of a hook. This
smells wrong. You should instead get the value out of the RenderFrame.

[megjablon, 2015/08/27 23:11:02]

Without PlageLoadHistograms being a subclass of RenderFrameObserver, we have to
pass this value in.

[davidben, 2015/08/31 23:43:24]

I'll defer to nasko, but I would think it's possible to get the RenderFrameHost
out of the WebFrame. Alternatively, it PageLoadHistograms is fairly small. Can
we convert that to RenderFrameHostObserver?

[megjablon, 2015/09/09 20:54:16]

Done.

   virtual void PrintPage(blink::WebLocalFrame* frame, bool user_initiated) {}
   virtual void FocusedNodeChanged(const blink::WebNode& node) {}
   virtual void DraggableRegionsChanged(blink::WebFrame* frame) {}
   virtual void DidCommitCompositorFrame() {}
   virtual void DidUpdateLayout() {}
 
   // These match the RenderView methods.
   virtual void DidHandleGestureEvent(const blink::WebGestureEvent& event) {}
 
   virtual void OnMouseDown(const blink::WebNode& mouse_down_node) {}
 
   // These match incoming IPCs.
   virtual void Navigate(const GURL& url) {}
-  virtual void ClosePage() {}
+  virtual void ClosePage(bool lofi_used) {}

[davidben, 2015/08/27 18:53:50]

Ditto.

[megjablon, 2015/09/09 20:54:16]

Done.

 
   // This indicates that animations to scroll the focused element into view (if
   // any) have completed. May be called more than once for a single focus. Can
   // be called from browser, renderer, or compositor.
   virtual void FocusChangeComplete() {}
 
   virtual void OnStop() {}
   virtual void OnZoomLevelChanged() {}
 
   // IPC::Listener implementation.
@@ skipping 25 matching lines @@
   RenderView* render_view_;
   // The routing ID of the associated RenderView.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_