Consistently use LoFi for an entire page

content/common/navigation_params.h

Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 37b1af035401ee8e9ab394831888b68c6519e4e9..add2a89eeca35433effddef80f214d4f55d81cc9 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -22,6 +22,17 @@ class RefCountedMemory;
 
 namespace content {
 
+// The LoFi state which determines whether to add the LoFi header. Must stay in
+// sync with the enum in url_request.h.

[davidben, 2015/08/27 18:53:50]

There is no reason for this. The enum shouldn't be in url_request.h at all.

[megjablon, 2015/08/27 23:11:02]

Using URLRequest in
DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal is how we
add q=low to the Chrome-Proxy header.

+enum LoFiState {
+  // Request a LoFi version of the resource.
+  LOFI_ON = 0,
+  // Request a normal (non-LoFi) version of the resource.
+  LOFI_OFF,
+  // Let the browser process decide whether or not to request the LoFi version.
+  LOFI_DEFAULT,
+};
+
 // PlzNavigate
 // Helper function to determine if the navigation to |url| should make a request
 // to the network stack. A request should not be sent for data URLs, JavaScript
@@ -191,7 +202,8 @@ struct CONTENT_EXPORT RequestNavigationParams {
                           int pending_history_list_offset,
                           int current_history_list_offset,
                           int current_history_list_length,
-                          bool should_clear_history_list);
+                          bool should_clear_history_list,
+                          int lofi_state);

[davidben, 2015/08/27 18:53:50]

Use your enum, not an int.

[megjablon, 2015/08/27 23:11:02]

Done.

   ~RequestNavigationParams();
 
   // Whether or not the user agent override string should be used.
@@ -257,6 +269,10 @@ struct CONTENT_EXPORT RequestNavigationParams {
   // needs to notify the browser that the clearing was succesful when the
   // navigation commits.
   bool should_clear_history_list;
+
+  // Whether or not to request a LoFi version of the resource or let the browser
+  // decide.
+  int lofi_state;

[davidben, 2015/08/27 18:53:50]

Use your enum, not an int.

[megjablon, 2015/08/27 23:11:02]

Using the enum instead of an int breaks IPC compilation. RequestNavigationParams
is sent over IPC using an IPC struct and I don't know of a way for an enum to be
a member. 

[davidben, 2015/08/31 23:43:24]

nasko would be a better person to answer this than me. It is definitely possible
to send enums over IPC; content::ResourceType, for instance. It looks like you
need this. This also resolves not checking the macros.

https://code.google.com/p/chromium/codesearch#chromium/src/ipc/ipc_message_ma...

[megjablon, 2015/09/09 20:54:15]

Done.

 };
 
 // Helper struct keeping track in one place of all the parameters the browser