Consistently use LoFi for an entire page

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/time/time.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_message_enums.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/referrer.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 
 namespace base {
 class RefCountedMemory;
 }
 
 namespace content {
 
+// The LoFi state which determines whether to add the LoFi header. Must stay in
+// sync with the enum in url_request.h.

[davidben, 2015/08/27 18:53:50]

There is no reason for this. The enum shouldn't be in url_request.h at all.

[megjablon, 2015/08/27 23:11:02]

Using URLRequest in
DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal is how we
add q=low to the Chrome-Proxy header.

+enum LoFiState {
+  // Request a LoFi version of the resource.
+  LOFI_ON = 0,
+  // Request a normal (non-LoFi) version of the resource.
+  LOFI_OFF,
+  // Let the browser process decide whether or not to request the LoFi version.
+  LOFI_DEFAULT,
+};
+
 // PlzNavigate
 // Helper function to determine if the navigation to |url| should make a request
 // to the network stack. A request should not be sent for data URLs, JavaScript
 // URLs or about:blank. In these cases, no request needs to be sent.
 bool ShouldMakeNetworkRequestForURL(const GURL& url);
 
 // The following structures hold parameters used during a navigation. In
 // particular they are used by FrameMsg_Navigate, FrameMsg_CommitNavigation and
 // FrameHostMsg_BeginNavigation.
 
@@ skipping 149 matching lines @@
                           base::Time request_time,
                           const PageState& page_state,
                           int32 page_id,
                           int nav_entry_id,
                           bool is_same_document_history_load,
                           bool has_committed_real_load,
                           bool intended_as_new_entry,
                           int pending_history_list_offset,
                           int current_history_list_offset,
                           int current_history_list_length,
-                          bool should_clear_history_list);
+                          bool should_clear_history_list,
+                          int lofi_state);

[davidben, 2015/08/27 18:53:50]

Use your enum, not an int.

[megjablon, 2015/08/27 23:11:02]

Done.

   ~RequestNavigationParams();
 
   // Whether or not the user agent override string should be used.
   bool is_overriding_user_agent;
 
   // The navigationStart time to expose through the Navigation Timing API to JS.
   base::TimeTicks browser_navigation_start;
 
   // Any redirect URLs that occurred before |url|. Useful for cross-process
   // navigations; defaults to empty.
@@ skipping 45 matching lines @@
 
   // Where its current page contents reside in session history and the total
   // size of the session history list.
   int current_history_list_offset;
   int current_history_list_length;
 
   // Whether session history should be cleared. In that case, the RenderView
   // needs to notify the browser that the clearing was succesful when the
   // navigation commits.
   bool should_clear_history_list;
+
+  // Whether or not to request a LoFi version of the resource or let the browser
+  // decide.
+  int lofi_state;

[davidben, 2015/08/27 18:53:50]

Use your enum, not an int.

[megjablon, 2015/08/27 23:11:02]

Using the enum instead of an int breaks IPC compilation. RequestNavigationParams
is sent over IPC using an IPC struct and I don't know of a way for an enum to be
a member. 

[davidben, 2015/08/31 23:43:24]

nasko would be a better person to answer this than me. It is definitely possible
to send enums over IPC; content::ResourceType, for instance. It looks like you
need this. This also resolves not checking the macros.

https://code.google.com/p/chromium/codesearch#chromium/src/ipc/ipc_message_ma...

[megjablon, 2015/09/09 20:54:15]

Done.

 };
 
 // Helper struct keeping track in one place of all the parameters the browser
 // needs to provide to the renderer.
 struct NavigationParams {
   NavigationParams(const CommonNavigationParams& common_params,
                    const StartNavigationParams& start_params,
                    const RequestNavigationParams& request_params);
   ~NavigationParams();
 
   CommonNavigationParams common_params;
   StartNavigationParams start_params;
   RequestNavigationParams request_params;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_