Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 131071: Implement window open disposition for (some) navigation buttons.... (Closed)

Created:
11 years, 6 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Implement window open disposition for (some) navigation buttons. still need to do similar for link buttons and such. BUG=14518 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18786

Patch Set 1 #

Patch Set 2 : bool->int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -5 lines) Patch
M chrome/browser/gtk/back_forward_button_gtk.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/gtk/back_forward_button_gtk.cc View 6 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 5 chunks +18 lines, -3 lines 0 comments Download
M chrome/common/gtk_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/gtk_util.cc View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
so there's a corner case where you can (for example) start a middle click on ...
11 years, 6 months ago (2009-06-18 22:47:33 UTC) #1
Elliot Glaysher
11 years, 6 months ago (2009-06-19 01:17:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698