Issue 131071: Implement window open disposition for (some) navigation buttons....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131071: Implement window open disposition for (some) navigation buttons.... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher, Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Implement window open disposition for (some) navigation buttons. still need to do similar for link buttons and such. BUG=14518 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18786

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -5 lines)			Patch
M	chrome/browser/gtk/back_forward_button_gtk.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/back_forward_button_gtk.cc	View		6 chunks	+20 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1	5 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/common/gtk_util.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View		2 chunks	+34 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Evan Stade

so there's a corner case where you can (for example) start a middle click on ...

11 years, 6 months ago (2009-06-18 22:47:33 UTC) #1

LGTM