Implement window open disposition for (some) navigation buttons....

chrome/browser/gtk/back_forward_button_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/back_forward_button_gtk.h"
 
 #include <gtk/gtk.h>
 
 #include "app/l10n_util.h"
 #include "base/message_loop.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/gtk/back_forward_menu_model_gtk.h"
 #include "chrome/browser/gtk/menu_gtk.h"
+#include "chrome/common/gtk_util.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 
 // The time in milliseconds between when the user clicks and the menu appears.
 static const int kMenuTimerDelay = 500;
 
 BackForwardButtonGtk::BackForwardButtonGtk(Browser* browser, bool is_forward)
     : browser_(browser),
       is_forward_(is_forward),
+      last_release_event_flags_(0),
       show_menu_factory_(this) {
   int normal, active, highlight, depressed, tooltip;
   if (is_forward) {
     normal = IDR_FORWARD;
     active = IDR_FORWARD_P;
     highlight = IDR_FORWARD_H;
     depressed = IDR_FORWARD_D;
     tooltip = IDS_TOOLTIP_FORWARD;
   } else {
     normal = IDR_BACK;
     active = IDR_BACK_P;
     highlight = IDR_BACK_H;
     depressed = IDR_BACK_D;
     tooltip = IDS_TOOLTIP_BACK;
   }
   button_.reset(new CustomDrawButton(normal, active, highlight, depressed));
   gtk_widget_set_tooltip_text(widget(),
                               l10n_util::GetStringUTF8(tooltip).c_str());
   menu_model_.reset(new BackForwardMenuModelGtk(browser,
       is_forward ?
           BackForwardMenuModel::FORWARD_MENU :
           BackForwardMenuModel::BACKWARD_MENU,
       this));
 
   g_signal_connect(widget(), "clicked",
                    G_CALLBACK(OnClick), this);
   g_signal_connect(widget(), "button-press-event",
                    G_CALLBACK(OnButtonPress), this);
+  g_signal_connect(widget(), "button-release-event",
+                   G_CALLBACK(OnButtonRelease), this);
   gtk_widget_add_events(widget(), GDK_POINTER_MOTION_MASK);
   g_signal_connect(widget(), "motion-notify-event",
                    G_CALLBACK(OnMouseMove), this);
 
   // Popup the menu as left-aligned relative to this widget rather than the
   // default of right aligned.
   g_object_set_data(G_OBJECT(widget()), "left-align-popup",
                     reinterpret_cast<void*>(true));
+
+  gtk_util::SetButtonTriggersNavigation(widget());
 }
 
 BackForwardButtonGtk::~BackForwardButtonGtk() {
 }
 
 void BackForwardButtonGtk::StoppedShowingMenu() {
   button_->UnsetPaintOverride();
 }
 
 void BackForwardButtonGtk::ShowBackForwardMenu() {
   menu_.reset(new MenuGtk(menu_model_.get(), true));
   button_->SetPaintOverride(GTK_STATE_ACTIVE);
 
   // gtk_menu_popup will ignore the first mouse button release if it matches
   // the button type and is within a short span of the time we pass here.
   // Since this menu is not popped up by a button press (instead, it is popped
   // up either on a timer or on a drag) this doesn't apply to us and we can
   // pass arbitrary values.
   menu_->Popup(widget(), 1, gtk_get_current_event_time());
 }
 
 // static
 void BackForwardButtonGtk::OnClick(GtkWidget* widget,
                                    BackForwardButtonGtk* button) {
   button->show_menu_factory_.RevokeAll();
 
-  button->browser_->ExecuteCommand(button->is_forward_ ?
-                                   IDC_FORWARD : IDC_BACK);
+  DCHECK(button->last_release_event_flags_ != 0);
+  button->browser_->ExecuteCommandWithDisposition(
+      button->is_forward_ ? IDC_FORWARD : IDC_BACK,
+      event_utils::DispositionFromEventFlags(
+          button->last_release_event_flags_));
 }
 
 // static
 gboolean BackForwardButtonGtk::OnButtonPress(GtkWidget* widget,
     GdkEventButton* event, BackForwardButtonGtk* button) {
+  button->last_release_event_flags_ = 0;
+
   if (event->button != 1)
     return FALSE;
 
   button->y_position_of_last_press_ = event->y;
   MessageLoop::current()->PostDelayedTask(FROM_HERE,
       button->show_menu_factory_.NewRunnableMethod(
           &BackForwardButtonGtk::ShowBackForwardMenu),
       kMenuTimerDelay);
   return FALSE;
 }
 
 // static
+gboolean BackForwardButtonGtk::OnButtonRelease(GtkWidget* widget,
+    GdkEventButton* event, BackForwardButtonGtk* button) {
+  button->last_release_event_flags_ = event->state;
+  return FALSE;
+}
+
+// static
 gboolean BackForwardButtonGtk::OnMouseMove(GtkWidget* widget,
     GdkEventMotion* event, BackForwardButtonGtk* button) {
   // If we aren't waiting to show the back forward menu, do nothing.
   if (button->show_menu_factory_.empty())
     return FALSE;
 
   // We only count moves about a certain threshold.
   GtkSettings* settings = gtk_widget_get_settings(widget);
   int drag_min_distance;
   g_object_get(settings, "gtk-dnd-drag-threshold", &drag_min_distance, NULL);
   if (event->y - button->y_position_of_last_press_ < drag_min_distance)
     return FALSE;
 
   // We will show the menu now. Cancel the delayed event.
   button->show_menu_factory_.RevokeAll();
   button->ShowBackForwardMenu();
   return FALSE;
 }