Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1310663007: Fix splash screen tests by adding rounding slop. (Closed)

Created:
5 years, 3 months ago by Ted C
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix splash screen tests by adding rounding slop. BUG=529543 Committed: https://crrev.com/2514eb9bbfbc540984221304b02eb33704082adb Cr-Commit-Position: refs/heads/master@{#347869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310663007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310663007/1
5 years, 3 months ago (2015-09-09 01:38:23 UTC) #2
gone
lgtm
5 years, 3 months ago (2015-09-09 01:44:38 UTC) #4
gone
Really should be fixed by rounding properly at the source, though.
5 years, 3 months ago (2015-09-09 01:46:53 UTC) #6
Ted C
On 2015/09/09 01:46:53, dfalcantara wrote: > Really should be fixed by rounding properly at the ...
5 years, 3 months ago (2015-09-09 01:47:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310663007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310663007/1
5 years, 3 months ago (2015-09-09 07:24:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 09:06:20 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:07:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2514eb9bbfbc540984221304b02eb33704082adb
Cr-Commit-Position: refs/heads/master@{#347869}

Powered by Google App Engine
This is Rietveld 408576698