chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java - Issue 1310663007: Fix splash screen tests by adding rounding slop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 1310663007: Fix splash screen tests by adding rounding slop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

index 5a1a236dbb976246080382dae326b11b19a2799f..c2a8c252a51f70fabc27832428265db59fa81736 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

@@ -558,7 +558,11 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

// Test that bitmap sizes match expectations.

int idealSize = getActivity().getResources().getDimensionPixelSize(

R.dimen.webapp_splash_image_size);

- assertEquals(idealSize, dataStorageFactory.mSplashImage.getWidth());

- assertEquals(idealSize, dataStorageFactory.mSplashImage.getHeight());

+ assertTrue("Expected width: " + idealSize + ", Actual: "

+ + dataStorageFactory.mSplashImage.getWidth(),

+ Math.abs(idealSize - dataStorageFactory.mSplashImage.getWidth()) <= 1);

+ assertTrue("Expected height: " + idealSize + ", Actual: "

+ + dataStorageFactory.mSplashImage.getHeight(),

+ Math.abs(idealSize - dataStorageFactory.mSplashImage.getHeight()) <= 1);

}