Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310643004: [bindings] Cleanup unused method v8ValueUnsafe from ScriptValue (Closed)

Created:
5 years, 4 months ago by vivekg_samsung
Modified:
5 years, 4 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Cleanup unused method v8ValueUnsafe from ScriptValue Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/bindings/core/v8/ScriptValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
vivekg
PTAL.
5 years, 4 months ago (2015-08-24 05:27:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310643004/1
5 years, 4 months ago (2015-08-24 05:30:20 UTC) #4
haraken
LGTM
5 years, 4 months ago (2015-08-24 06:01:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310643004/1
5 years, 4 months ago (2015-08-24 06:01:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102932)
5 years, 4 months ago (2015-08-24 06:22:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310643004/1
5 years, 4 months ago (2015-08-24 06:23:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102946)
5 years, 4 months ago (2015-08-24 07:57:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310643004/1
5 years, 4 months ago (2015-08-24 08:15:57 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 09:07:25 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201052

Powered by Google App Engine
This is Rietveld 408576698