Source/bindings/core/v8/ScriptValue.cpp - Issue 1310643004: [bindings] Cleanup unused method v8ValueUnsafe from ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptValue.cpp

Issue 1310643004: [bindings] Cleanup unused method v8ValueUnsafe from ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptValue.cpp

diff --git a/Source/bindings/core/v8/ScriptValue.cpp b/Source/bindings/core/v8/ScriptValue.cpp

index 0bb8d90f018e1d5b770cf14afaa98effb0f7e532..87dae7d41b17f99a9053b1adf9a73c438138eae3 100644

--- a/Source/bindings/core/v8/ScriptValue.cpp

+++ b/Source/bindings/core/v8/ScriptValue.cpp

@@ -55,13 +55,6 @@ v8::Local<v8::Value> ScriptValue::v8Value() const

return m_value->newLocal(isolate());

}

-v8::Local<v8::Value> ScriptValue::v8ValueUnsafe() const

- if (isEmpty())

- return v8::Local<v8::Value>();

- return m_value->newLocal(isolate());

v8::Local<v8::Value> ScriptValue::v8ValueFor(ScriptState* targetScriptState) const

{

if (isEmpty())

« no previous file with comments | « Source/bindings/core/v8/ScriptValue.h ('k') | no next file » | no next file with comments »