Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 131063006: Revert 244098 "Fix chromeos=1 so Pulse is preferred when use_cra..." (Closed)

Created:
6 years, 11 months ago by dcheng
Modified:
6 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244098 "Fix chromeos=1 so Pulse is preferred when use_cra..." Speculative revert to fix link errors on ChromiumOS amd64 BuildPackages, complaining about undefined reference to 'alsa_util::BitsToFormat(int)'. > Fix chromeos=1 so Pulse is preferred when use_cras=0. > > Merges the settings for use_alsa and use_pulseaudio for selection > based on use_cras. > > BUG=none > TEST=Pulse is available along with ALSA when chromeos=1. > > Review URL: https://codereview.chromium.org/132773002 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M trunk/src/media/media.gyp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
6 years, 11 months ago (2014-01-10 05:52:13 UTC) #1
dcheng
Committed patchset #1 manually as r244100.
6 years, 11 months ago (2014-01-10 05:52:31 UTC) #2
DaleCurtis
Do you have a link to the builder? I didn't get an email about this ...
6 years, 11 months ago (2014-01-10 17:55:49 UTC) #3
DaleCurtis
6 years, 11 months ago (2014-01-10 17:57:17 UTC) #4
Message was sent while issue was closed.
Nevermind, found it:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd6...

Powered by Google App Engine
This is Rietveld 408576698