Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 131063003: Revert of Introduce TextFinder class. (Closed)

Created:
6 years, 11 months ago by alph
Modified:
6 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@upload-review-4
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/69923006/ Reason for revert: Probably the cause of FindInPageTest.FocusRestore interactive_ui_tests failure http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13181 TBR=yosin@chromium.org,tkent@chromium.org,eseidel@chromium.org,iceman@yandex-team.ru NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3078 lines, -337 lines) Patch
M Source/web/TextFinder.h View 7 chunks +316 lines, -60 lines 0 comments Download
M Source/web/TextFinder.cpp View 25 chunks +1934 lines, -197 lines 0 comments Download
M Source/web/WebFrameImpl.h View 4 chunks +169 lines, -9 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 13 chunks +659 lines, -69 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
Created Revert of Introduce TextFinder class.
6 years, 11 months ago (2014-01-09 19:52:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/131063003/1
6 years, 11 months ago (2014-01-09 19:52:52 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/web/TextFinder.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-09 19:52:55 UTC) #3
tkent
Was this reverted? Or were the failures caused by another change?
6 years, 11 months ago (2014-01-14 00:17:57 UTC) #4
alph
6 years, 11 months ago (2014-01-14 13:32:24 UTC) #5
On 2014/01/14 00:17:57, tkent wrote:
> Was this reverted? Or were the failures caused by another change?

Yes, it has been reverted within other CL:
https://codereview.chromium.org/132563003

I'm closing this one.

Powered by Google App Engine
This is Rietveld 408576698