Issue 132563003: Revert 164780 "Introduce TextFinder class for decoupling WebFram..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132563003: Revert 164780 "Introduce TextFinder class for decoupling WebFram..." (Closed)

Created:
6 years, 11 months ago by Fady Samuel

Modified:
6 years, 11 months ago

Reviewers:
Andrey Kraynov

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 164780 "Introduce TextFinder class for decoupling WebFram..." > Introduce TextFinder class for decoupling WebFrameImpl and text finder. > > It will be lazily initialized when user activates find on page functionality. > > BUG= > > Review URL: https://codereview.chromium.org/69923006 TBR=iceman@yandex-team.ru Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164801

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2953 lines, -269 lines)			Patch
M	trunk/Source/web/TextFinder.h	View	7 chunks	+309 lines, -53 lines	0 comments	Download
M	trunk/Source/web/TextFinder.cpp	View	25 chunks	+1828 lines, -148 lines	0 comments	Download
M	trunk/Source/web/WebFrameImpl.h	View	4 chunks	+169 lines, -9 lines	0 comments	Download
M	trunk/Source/web/WebFrameImpl.cpp	View	13 chunks	+647 lines, -57 lines	0 comments	Download
M	trunk/Source/web/web.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r164801.