[css-grid] Add coverage for min-height behavior

[css-grid] Add coverage for min-height behavior

We were only testing the default value for align-items (stretch),
but not other values (like we do for justify-items).

Modified the test to check the non-stretch behavior too.

BUG=510061
TEST=fast/css-grid-layout/min-width-height-auto.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201797

[Manuel Rego, 2015-09-03 08:06:56]

Just adding some extra coverage to our tests once that
http://crrev.com/1228983003/ has landed.

More info at:
https://code.google.com/p/chromium/issues/detail?id=510061#c4

[Manuel Rego, 2015-09-03 08:07:18]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[jfernandez, 2015-09-03 09:16:51]

lgtm

[svillar, 2015-09-03 13:24:36]

https://codereview.chromium.org/1310603008/diff/1/LayoutTests/fast/css-grid-l...
File LayoutTests/fast/css-grid-layout/min-width-height-auto.html (right):

https://codereview.chromium.org/1310603008/diff/1/LayoutTests/fast/css-grid-l...
LayoutTests/fast/css-grid-layout/min-width-height-auto.html:88: <div class="ahem
minSmaller" data-expected-width="100" data-expected-height="25">XXXX</div>
Although adding more test cases is nice I don't get why setting a min-height was
forcing the item to be 10px height before your change. That means that we have a
bug there because in the test just above this one, the item is 25px height so
setting a min-height must not shrink the item.

[Manuel Rego, 2015-09-04 13:59:17]

Thanks for the reviews!

https://codereview.chromium.org/1310603008/diff/1/LayoutTests/fast/css-grid-l...
File LayoutTests/fast/css-grid-layout/min-width-height-auto.html (right):

https://codereview.chromium.org/1310603008/diff/1/LayoutTests/fast/css-grid-l...
LayoutTests/fast/css-grid-layout/min-width-height-auto.html:88: <div class="ahem
minSmaller" data-expected-width="100" data-expected-height="25">XXXX</div>
On 2015/09/03 13:24:36, svillar wrote:
> Although adding more test cases is nice I don't get why setting a min-height
was
> forcing the item to be 10px height before your change. That means that we have
a
> bug there because in the test just above this one, the item is 25px height so
> setting a min-height must not shrink the item.

Yeah, I agree this is weird, but per spec the item can stretch or shrink when
using "stretch":
https://drafts.csswg.org/css-align/#stretch

Shrink doesn't happen usually because of the default "min-widht|height: auto;".

I've added more info in the bug regarding this for future reference:
https://code.google.com/p/chromium/issues/detail?id=510061#c5

[svillar, 2015-09-04 14:34:01]

Fair enough, lgtm.

[Manuel Rego, 2015-09-04 14:35:58]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2015-09-04 14:36:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310603008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310603008/1

[commit-bot: I haz the power, 2015-09-04 15:19:53]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201797