Chromium Code Reviews Chromium Code Reviews
Issue 1310603008:
[css-grid] Add coverage for min-height behavior (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <link href="resources/grid.css" rel="stylesheet"> | 3 <link href="resources/grid.css" rel="stylesheet"> |
| 4 <style> | 4 <style> |
| 5 .grid { | 5 .grid { |
| 6 grid-template-columns: 5px; | 6 grid-template-columns: 5px; |
| 7 grid-template-rows: 5px; | 7 grid-template-rows: 5px; |
| 8 } | 8 } |
| 9 | 9 |
| 10 .container { | 10 .container { |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 max-width: 10px; | 30 max-width: 10px; |
| 31 max-height: 10px; | 31 max-height: 10px; |
| 32 } | 32 } |
| 33 | 33 |
| 34 .maxBigger { | 34 .maxBigger { |
| 35 max-width: 150px; | 35 max-width: 150px; |
| 36 max-height: 75px; | 36 max-height: 75px; |
| 37 } | 37 } |
| 38 | 38 |
| 39 .noStretch { | 39 .noStretch { |
| 40 align-items: start; | |
| 40 justify-items: start; | 41 justify-items: start; |
| 41 } | 42 } |
| 42 </style> | 43 </style> |
| 43 <script src="../../resources/check-layout.js"></script> | 44 <script src="../../resources/check-layout.js"></script> |
| 44 <body onload="checkLayout('.grid')"> | 45 <body onload="checkLayout('.grid')"> |
| 45 | 46 |
| 46 <p>This test checks min-width|height auto behavior for grids</p> | 47 <p>This test checks min-width|height auto behavior for grids</p> |
| 47 | 48 |
| 48 <div class="container"> | 49 <div class="container"> |
| 49 <div class="grid"> | 50 <div class="grid"> |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 77 | 78 |
| 78 <!-- Verify that the same cases without 'stretch' work as expected as well. --> | 79 <!-- Verify that the same cases without 'stretch' work as expected as well. --> |
| 79 <div class="container"> | 80 <div class="container"> |
| 80 <div class="grid noStretch"> | 81 <div class="grid noStretch"> |
| 81 <div class="ahem" data-expected-width="100" data-expected-height="25">XX XX</div> | 82 <div class="ahem" data-expected-width="100" data-expected-height="25">XX XX</div> |
| 82 </div> | 83 </div> |
| 83 </div> | 84 </div> |
| 84 | 85 |
| 85 <div class="container"> | 86 <div class="container"> |
| 86 <div class="grid noStretch"> | 87 <div class="grid noStretch"> |
| 87 <div class="ahem minSmaller" data-expected-width="100" data-expected-hei ght="10">XXXX</div> | 88 <div class="ahem minSmaller" data-expected-width="100" data-expected-hei ght="25">XXXX</div> |
|
svillar
2015/09/03 13:24:36
Although adding more test cases is nice I don't ge
Manuel Rego
2015/09/04 13:59:17
Yeah, I agree this is weird, but per spec the item
| |
| 88 </div> | 89 </div> |
| 89 </div> | 90 </div> |
| 90 | 91 |
| 91 <div class="container"> | 92 <div class="container"> |
| 92 <div class="grid noStretch"> | 93 <div class="grid noStretch"> |
| 93 <div class="ahem minBigger" data-expected-width="150" data-expected-heig ht="75">XXXX</div> | 94 <div class="ahem minBigger" data-expected-width="150" data-expected-heig ht="75">XXXX</div> |
| 94 </div> | 95 </div> |
| 95 </div> | 96 </div> |
| 96 | 97 |
| 97 <div class="container"> | 98 <div class="container"> |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 114 </div> | 115 </div> |
| 115 | 116 |
| 116 <div class="container"> | 117 <div class="container"> |
| 117 <div class="grid noStretch"> | 118 <div class="grid noStretch"> |
| 118 <div class="ahem" data-expected-width="75" data-expected-height="50">XXX X</div> | 119 <div class="ahem" data-expected-width="75" data-expected-height="50">XXX X</div> |
| 119 </div> | 120 </div> |
| 120 </div> | 121 </div> |
| 121 | 122 |
| 122 </body> | 123 </body> |
| 123 </html> | 124 </html> |
| OLD | NEW |
