Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310573008: Revert[2] of "switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE" (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] of "switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE" master-skia has been updated to use isABitmap This reverts commit ff390c9bdd852405d9dc0fd5e384b1f935d8df08. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0f0af23889ee631a395a3e19a5d3b63d7ce945bb

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -49 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShader.h View 2 chunks +11 lines, -33 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
5 years, 3 months ago (2015-09-08 17:43:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310573008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310573008/20001
5 years, 3 months ago (2015-09-08 17:43:52 UTC) #4
reed1
ptal
5 years, 3 months ago (2015-09-08 17:44:49 UTC) #6
scroggo
On 2015/09/08 17:44:49, reed1 wrote: > ptal LGTM
5 years, 3 months ago (2015-09-08 17:52:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310573008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310573008/20001
5 years, 3 months ago (2015-09-08 18:01:27 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 18:02:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0f0af23889ee631a395a3e19a5d3b63d7ce945bb

Powered by Google App Engine
This is Rietveld 408576698