Remove code link from serialization state.

Remove code link from serialization state.

Code::WipeOutHeader now nulls out the next code link to avoid
embedding that address in snapshot.

BUG=
LOG=NO

Committed: https://crrev.com/d779181b8847ecdcdeadb2b49980cc67f9ee9a69
Cr-Commit-Position: refs/heads/master@{#30544}

[oth, 2015-09-02 12:08:03]

oth@chromium.org changed reviewers:
+ machenbach@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org

[oth, 2015-09-02 12:08:04]

machenbach@chromium.org: PTAL
rmcilroy@chromium.org: PTAL

One line change that I'd discussed with Yang when looking at snapshot generation
issues for android.

yangguo@chromium.org: JFYI

[rmcilroy, 2015-09-02 12:33:52]

rmcilroy@chromium.org changed reviewers:
+ hpayer@chromium.org

[rmcilroy, 2015-09-02 12:33:53]

lgtm with a question for Hannes.

https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h#newcode6420
src/objects-inl.h:6420: WRITE_FIELD(this, kNextCodeLinkOffset, NULL);
+hpayer

Should we also wipeout kGCMetadataOffset ?

[Yang, 2015-09-02 12:58:28]

On 2015/09/02 12:33:53, rmcilroy wrote:
> lgtm with a question for Hannes.
> 
> https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h
> File src/objects-inl.h (right):
> 
>
https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h#newcode6420
> src/objects-inl.h:6420: WRITE_FIELD(this, kNextCodeLinkOffset, NULL);
> +hpayer
> 
> Should we also wipeout kGCMetadataOffset ?

lgtm

[Michael Achenbach, 2015-09-02 13:02:53]

On 2015/09/02 12:58:28, Yang OOO until mid October wrote:
> On 2015/09/02 12:33:53, rmcilroy wrote:
> > lgtm with a question for Hannes.
> > 
> > https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h
> > File src/objects-inl.h (right):
> > 
> >
>
https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h#newcode6420
> > src/objects-inl.h:6420: WRITE_FIELD(this, kNextCodeLinkOffset, NULL);
> > +hpayer
> > 
> > Should we also wipeout kGCMetadataOffset ?
> 
> lgtm

I can't say anything to the code, but please shorten the first line of the
description, so that it's more readable after committing. You can add more lines
afterwards with the details.

[oth, 2015-09-02 14:16:24]

The CQ bit was checked by oth@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 14:16:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310503006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310503006/1

[oth, 2015-09-02 14:17:01]

On 2015/09/02 13:02:53, Michael Achenbach wrote:
> On 2015/09/02 12:58:28, Yang OOO until mid October wrote:
> > On 2015/09/02 12:33:53, rmcilroy wrote:
> > > lgtm with a question for Hannes.
> > > 
> > > https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h
> > > File src/objects-inl.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h#newcode6420
> > > src/objects-inl.h:6420: WRITE_FIELD(this, kNextCodeLinkOffset, NULL);
> > > +hpayer
> > > 
> > > Should we also wipeout kGCMetadataOffset ?
> > 
> > lgtm
> 
> I can't say anything to the code, but please shorten the first line of the
> description, so that it's more readable after committing. You can add more
lines
> afterwards with the details.

Thanks all.

[oth, 2015-09-02 14:21:43]

On 2015/09/02 12:33:53, rmcilroy wrote:
> lgtm with a question for Hannes.
> 
> https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h
> File src/objects-inl.h (right):
> 
>
https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h#newcode6420
> src/objects-inl.h:6420: WRITE_FIELD(this, kNextCodeLinkOffset, NULL);
> +hpayer
> 
> Should we also wipeout kGCMetadataOffset ?

From a practical standpoint, it's just the code link field that's writing a
non-null address into the snapshot. Correctness may dictate otherwise.

[commit-bot: I haz the power, 2015-09-02 14:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 14:41:54]

Dry run: This issue passed the CQ dry run.

[oth, 2015-09-02 14:42:36]

The CQ bit was checked by oth@chromium.org

[commit-bot: I haz the power, 2015-09-02 14:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310503006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310503006/1

[commit-bot: I haz the power, 2015-09-02 14:44:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-02 14:44:21]

Patchset 1 (id:??) landed as
https://crrev.com/d779181b8847ecdcdeadb2b49980cc67f9ee9a69
Cr-Commit-Position: refs/heads/master@{#30544}