Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: components/bubble/bubble_controller.cc

Issue 1310483003: Add ability for a BubbleReference to update the BubbleUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bm-reference-own-file.gitbr
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bubble/bubble_controller.cc
diff --git a/components/bubble/bubble_controller.cc b/components/bubble/bubble_controller.cc
index e32cd21716428aa0845c41c6a865a6c4ff0b1849..eebe6c61b2aee5b5e6cb0cd029e0e331127ceab1 100644
--- a/components/bubble/bubble_controller.cc
+++ b/components/bubble/bubble_controller.cc
@@ -24,6 +24,10 @@ bool BubbleController::CloseBubble(BubbleCloseReason reason) {
return manager_->CloseBubble(this->AsWeakPtr(), reason);
}
+bool BubbleController::UpdateBubbleUI() {
+ return manager_->UpdateBubbleUI(this->AsWeakPtr());
groby-ooo-7-16 2015/09/03 17:30:01 Does this need to flow through the manager? Who us
hcarmona 2015/09/03 18:05:53 Going through the manager ensures that we stay on
groby-ooo-7-16 2015/09/03 19:13:58 Do we _need_ to ensure that? And if we do, let's e
+}
+
void BubbleController::Show() {
DCHECK(!bubble_ui_);
bubble_ui_ = delegate_->BuildBubbleUI();
@@ -47,3 +51,9 @@ bool BubbleController::ShouldClose(BubbleCloseReason reason) {
}
return false;
}
+
+bool BubbleController::UpdateBubbleUIInternal() {
groby-ooo-7-16 2015/09/03 17:30:01 I decidedly dislike "Internal" functions. If we do
hcarmona 2015/09/03 18:05:53 Done.
+ if (!bubble_ui_)
+ return false;
+ return delegate_->UpdateBubbleUI(bubble_ui_.get());
+}

Powered by Google App Engine
This is Rietveld 408576698