Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/sync/glue/synced_tab_delegate.h

Issue 1310373009: [Sync] Remove static methods on SyncedWindowDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android compile. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/synced_tab_delegate.h
diff --git a/chrome/browser/sync/glue/synced_tab_delegate.h b/chrome/browser/sync/glue/synced_tab_delegate.h
index 0645e4eb949b532d44321ff70b5bbee64fd29ab8..e36d54ba438eed71acd1796931b63bb06312bfef 100644
--- a/chrome/browser/sync/glue/synced_tab_delegate.h
+++ b/chrome/browser/sync/glue/synced_tab_delegate.h
@@ -8,6 +8,8 @@
#include <string>
#include <vector>
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/sync/sessions/synced_window_delegates_getter.h"
#include "components/sessions/session_id.h"
class Profile;
@@ -24,7 +26,8 @@ class SyncedWindowDelegate;
// directly on WebContents, NavigationController, and the extensions TabHelper.
class SyncedTabDelegate {
public:
- virtual ~SyncedTabDelegate() {}
+ SyncedTabDelegate();
Nicolas Zea 2015/08/31 22:12:47 nit: I think it would be better to make this const
maxbogue 2015/09/01 17:29:27 Done.
+ virtual ~SyncedTabDelegate();
// Methods from TabContents.
@@ -69,6 +72,8 @@ class SyncedTabDelegate {
// Returns true if this tab should be synchronized.
bool ShouldSync() const;
+ void SetSyncedWindowGetter(scoped_ptr<SyncedWindowDelegatesGetter> getter);
Nicolas Zea 2015/08/31 22:12:47 Add comment? Would probably be good to also explai
maxbogue 2015/09/01 17:29:27 Done.
+
// Returns the SyncedTabDelegate associated with WebContents.
static SyncedTabDelegate* ImplFromWebContents(
content::WebContents* web_contents);
@@ -76,6 +81,8 @@ class SyncedTabDelegate {
protected:
// Overridden by the tests to avoid interaction with static state.
virtual const SyncedWindowDelegate* GetSyncedWindowDelegate() const;
+
+ scoped_ptr<SyncedWindowDelegatesGetter> synced_window_getter_;
Nicolas Zea 2015/08/31 22:12:47 make private?
maxbogue 2015/09/01 17:29:27 Done.
};
} // namespace browser_sync

Powered by Google App Engine
This is Rietveld 408576698