[Sync] Remove static methods on SyncedWindowDelegate.

chrome/browser/sync/glue/synced_tab_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SYNCED_TAB_DELEGATE_H__
 #define CHROME_BROWSER_SYNC_GLUE_SYNCED_TAB_DELEGATE_H__
 
 #include <string>
 #include <vector>
 
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/sync/sessions/synced_window_delegates_getter.h"
 #include "components/sessions/session_id.h"
 
 class Profile;
 
 namespace content {
 class NavigationEntry;
 class WebContents;
 }
 
 namespace browser_sync {
 class SyncedWindowDelegate;
 
 // A SyncedTabDelegate is used to insulate the sync code from depending
 // directly on WebContents, NavigationController, and the extensions TabHelper.
 class SyncedTabDelegate {
  public:
-  virtual ~SyncedTabDelegate() {}
+  SyncedTabDelegate();

[Nicolas Zea, 2015/08/31 22:12:47]

nit: I think it would be better to make this constructor protected to make it
clear that embedders should not be instantiating a SyncedTabDelegate directly,
but instead a derived class.

[maxbogue, 2015/09/01 17:29:27]

Done.

+  virtual ~SyncedTabDelegate();
 
   // Methods from TabContents.
 
   virtual SessionID::id_type GetWindowId() const = 0;
   virtual SessionID::id_type GetSessionId() const = 0;
   virtual bool IsBeingDestroyed() const = 0;
   virtual Profile* profile() const = 0;
 
   // Method derived from extensions TabHelper.
 
@@ skipping 24 matching lines @@
   virtual bool HasWebContents() const = 0;
   virtual content::WebContents* GetWebContents() const = 0;
 
   // Session sync related methods.
   virtual int GetSyncId() const = 0;
   virtual void SetSyncId(int sync_id) = 0;
 
   // Returns true if this tab should be synchronized.
   bool ShouldSync() const;
 
+  void SetSyncedWindowGetter(scoped_ptr<SyncedWindowDelegatesGetter> getter);

[Nicolas Zea, 2015/08/31 22:12:47]

Add comment? Would probably be good to also explain where/when this is supposed
to be called.

[maxbogue, 2015/09/01 17:29:27]

Done.

+
   // Returns the SyncedTabDelegate associated with WebContents.
   static SyncedTabDelegate* ImplFromWebContents(
       content::WebContents* web_contents);
 
  protected:
   // Overridden by the tests to avoid interaction with static state.
   virtual const SyncedWindowDelegate* GetSyncedWindowDelegate() const;
+
+  scoped_ptr<SyncedWindowDelegatesGetter> synced_window_getter_;

[Nicolas Zea, 2015/08/31 22:12:47]

make private?

[maxbogue, 2015/09/01 17:29:27]

Done.

 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SYNCED_TAB_DELEGATE_H__