Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 1310323004: Introduce positionForPoint() in LocalFrame class as replacement of visiblePositionForPoint() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, dcheng, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce positionForPoint() in LocalFrame class as replacement of visiblePositionForPoint() This patch introduces |positionForPoint()| in |LocalFrame| class as replacement of |visiblePositionForPoint()| to reduce doing visible position canonicalization for increasing chance to delay canonicalization with changing |setPosition()| in |DragCaretController| and |VisibleSelection| constructor to take |PositionWithAffinity|. Note: Both of |VisbilePosition| constructor and |VisibleSelection| constructor do visible position canaonicalization. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201110

Patch Set 1 : 2015-08-25T15:15:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M Source/core/editing/DragCaretController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/DragCaretController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-25 07:21:37 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-25 07:42:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310323004/1
5 years, 4 months ago (2015-08-25 08:06:37 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 08:11:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201110

Powered by Google App Engine
This is Rietveld 408576698