Introduce positionForPoint() in LocalFrame class as replacement of visiblePositionForPoint()

Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 654 matching lines @@
 String LocalFrame::selectedText() const
 {
     return selection().selectedText();
 }
 
 String LocalFrame::selectedTextForClipboard() const
 {
     return selection().selectedTextForClipboard();
 }
 
-VisiblePosition LocalFrame::visiblePositionForPoint(const IntPoint& framePoint)
+PositionWithAffinity LocalFrame::positionForPoint(const IntPoint& framePoint)
 {
     HitTestResult result = eventHandler().hitTestResultAtPoint(framePoint);
     Node* node = result.innerNodeOrImageMapImage();
     if (!node)
-        return VisiblePosition();
+        return PositionWithAffinity();
     LayoutObject* layoutObject = node->layoutObject();
     if (!layoutObject)
-        return VisiblePosition();
-    VisiblePosition visiblePos = VisiblePosition(layoutObject->positionForPoint(result.localPoint()));
-    if (visiblePos.isNull())
-        visiblePos = VisiblePosition(firstPositionInOrBeforeNode(node));
-    return visiblePos;
+        return PositionWithAffinity();
+    const PositionWithAffinity position = layoutObject->positionForPoint(result.localPoint());
+    if (position.isNull())
+        return PositionWithAffinity(firstPositionInOrBeforeNode(node));
+    return position;
 }
 
 Document* LocalFrame::documentAtPoint(const IntPoint& pointInRootFrame)
 {
     if (!view())
         return nullptr;
 
     IntPoint pt = view()->rootFrameToContents(pointInRootFrame);
 
     if (!contentLayoutObject())
         return nullptr;
     HitTestResult result = eventHandler().hitTestResultAtPoint(pt, HitTestRequest::ReadOnly | HitTestRequest::Active);
     return result.innerNode() ? &result.innerNode()->document() : nullptr;
 }
 
 EphemeralRange LocalFrame::rangeForPoint(const IntPoint& framePoint)
 {
-    VisiblePosition position = visiblePositionForPoint(framePoint);
-    if (position.isNull())
+    const PositionWithAffinity positionWithAffinity = positionForPoint(framePoint);
+    if (positionWithAffinity.isNull())
         return EphemeralRange();
 
+    VisiblePosition position(positionWithAffinity);
     VisiblePosition previous = position.previous();
     if (previous.isNotNull()) {
         const EphemeralRange previousCharacterRange = makeRange(previous, position);
         IntRect rect = editor().firstRectForRange(previousCharacterRange);
         if (rect.contains(framePoint))
             return EphemeralRange(previousCharacterRange);
     }
 
     VisiblePosition next = position.next();
     const EphemeralRange nextCharacterRange = makeRange(position, next);
@@ skipping 133 matching lines @@
 {
     if (isLocalRoot())
         m_instrumentingAgents = InstrumentingAgents::create();
     else
         m_instrumentingAgents = localFrameRoot()->m_instrumentingAgents;
 }
 
 DEFINE_WEAK_IDENTIFIER_MAP(LocalFrame);
 
 } // namespace blink