Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1310253004: Have VariationsService get version for simulation callback from client (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@variations_service_browser_thread
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have VariationsService get version for simulation callback from client To get the version to use for simulation, VariationsService relies on //chrome-level functionality on some platforms. This CL abstracts that functionality through VariationsServiceClient as part of enabling componentization of VariationsService. BUG=516682 Committed: https://crrev.com/449471f72daa60e1ac312945ad7f4244c4d0ad65 Cr-Commit-Position: refs/heads/master@{#345574}

Patch Set 1 #

Patch Set 2 : Update comment #

Patch Set 3 : Update comment again #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M chrome/browser/metrics/variations/chrome_variations_service_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 3 chunks +2 lines, -22 lines 0 comments Download
M components/variations/variations_service_client.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
blundell
5 years, 4 months ago (2015-08-24 19:03:03 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 4 months ago (2015-08-24 19:09:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310253004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310253004/160001
5 years, 4 months ago (2015-08-26 08:47:47 UTC) #6
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 4 months ago (2015-08-26 09:46:30 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 09:47:37 UTC) #8
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/449471f72daa60e1ac312945ad7f4244c4d0ad65
Cr-Commit-Position: refs/heads/master@{#345574}

Powered by Google App Engine
This is Rietveld 408576698