Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix review comments and update code as discussed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_debug_log.cc
diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc
index 0f56dd56223c8f529866506c78984ff20a7bc55b..f955cffe8532f90761bbd24994247520d4935a24 100644
--- a/chrome/browser/banners/app_banner_debug_log.cc
+++ b/chrome/browser/banners/app_banner_debug_log.cc
@@ -18,11 +18,15 @@ const char kRendererRequestCancel[] =
const char kManifestEmpty[] = "manifest is empty or missing";
const char kCannotDetermineBestIcon[] =
"could not determine the best icon to use";
+const char kCannotDetermineBestSplashIcon[] =
+ "could not determine the best splashscreen icon to use";
gone 2015/08/26 02:01:20 This one isn't used anywhere.
Lalit Maganti 2015/08/26 13:11:56 Removed. Was used earlier for logging but forgot t
const char kNoMatchingServiceWorker[] =
"no matching service worker detected. You may need to reload the page, or "
"check that the service worker for the current page also controls the "
"start URL from the manifest";
const char kNoIconAvailable[] = "no icon available to display";
+const char kNoSplashIconAvailable[] =
gone 2015/08/26 02:01:20 Neither is this.
Lalit Maganti 2015/08/26 13:11:56 As above.
+ "no splashscreen icon available to display";
const char kBannerAlreadyAdded[] =
"site requesting the banner has already been added";
const char kUserNavigatedBeforeBannerShown[] =

Powered by Google App Engine
This is Rietveld 408576698