Chromium Code Reviews| Index: chrome/browser/banners/app_banner_data_fetcher.h |
| diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h |
| index 69d647e801219a4ca5e2d304d6819025094c777a..31206c12cd4ee2c0b8dee4b26e1c8254a61ff120 100644 |
| --- a/chrome/browser/banners/app_banner_data_fetcher.h |
| +++ b/chrome/browser/banners/app_banner_data_fetcher.h |
| @@ -121,7 +121,7 @@ class AppBannerDataFetcher |
| // Called when it is determined that the webapp has fulfilled the initial |
| // criteria of having a manifest and a service worker. |
| - void OnHasServiceWorker(content::WebContents* web_contents); |
| + virtual void OnHasServiceWorker(content::WebContents* web_contents); |
|
Lalit Maganti
2015/08/26 13:11:56
Reverted this change as it is not necessary and al
|
| content::WebContents* GetWebContents(); |
| virtual std::string GetAppIdentifier(); |
| @@ -137,6 +137,10 @@ class AppBannerDataFetcher |
| // metric being recorded. |
| void RecordDidShowBanner(const std::string& event_name); |
| + // Returns whether the fetcher is active and web contents have not been |
| + // closed. |
| + bool CheckFetcherIsStillAlive(content::WebContents* web_contents); |
|
Lalit Maganti
2015/08/26 13:11:56
Reverted as no longer necessary.
|
| + |
| private: |
| // Callbacks for data retrieval. |
| void OnDidGetManifest(const content::Manifest& manifest); |
| @@ -160,10 +164,6 @@ class AppBannerDataFetcher |
| // Returns whether the banner should be shown. |
| bool CheckIfShouldShowBanner(); |
| - // Returns whether the fetcher is active and web contents have not been |
| - // closed. |
| - bool CheckFetcherIsStillAlive(content::WebContents* web_contents); |
| - |
| // Returns whether the given Manifest is following the requirements to show |
| // a web app banner. |
| static bool IsManifestValidForWebApp(const content::Manifest& manifest, |