Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix review comments and update code as discussed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 953c0e934e4eca9adaf4821cb644dc182130c3fd..c95830d2eb1147f0b3613c2bec84613a62b0620c 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -32,8 +32,10 @@ namespace banners {
AppBannerManagerAndroid::AppBannerManagerAndroid(JNIEnv* env,
jobject obj,
+ int splash_icon_size,
int icon_size)
: AppBannerManager(icon_size),
+ ideal_splash_icon_size_(splash_icon_size),
Lalit Maganti 2015/08/26 13:11:56 Changed this whole file have "ideal" and "in dp"
weak_java_banner_view_manager_(env, obj) {
}
@@ -134,6 +136,7 @@ AppBannerDataFetcher* AppBannerManagerAndroid::CreateAppBannerDataFetcher(
base::WeakPtr<Delegate> weak_delegate,
const int ideal_icon_size) {
return new AppBannerDataFetcherAndroid(web_contents(), weak_delegate,
+ ideal_splash_icon_size_,
ideal_icon_size);
}
@@ -167,9 +170,9 @@ bool AppBannerManagerAndroid::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-jlong Init(JNIEnv* env, jobject obj, jint icon_size) {
+jlong Init(JNIEnv* env, jobject obj, jint splash_icon_size, jint icon_size) {
AppBannerManagerAndroid* manager =
- new AppBannerManagerAndroid(env, obj, icon_size);
+ new AppBannerManagerAndroid(env, obj, splash_icon_size, icon_size);
return reinterpret_cast<intptr_t>(manager);
}

Powered by Google App Engine
This is Rietveld 408576698