webapps: initial addition of splash screen icon downloading

chrome/browser/android/shortcut_helper.h

Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 93e1c9d589a86307befc9bbc041867eb15ffadae..39604e471abbfc6a206ed10c9bddeb4ac96917f5 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -11,9 +11,8 @@
 #include "third_party/skia/include/core/SkBitmap.h"
 
 // ShortcutHelper is the C++ counterpart of org.chromium.chrome.browser's
-// ShortcutHelper in Java. The object is owned by the Java object. It is created
-// from there via a JNI (Initialize) call and MUST BE DESTROYED via Destroy().

[gone, 2015/08/26 02:01:19]

I asked you to update this comment when your original split happened.  Looks
like you landed it without addressing any of my comments from that patch set. 
Sloppy for me not checking the difference between your patch sets, and sloppy
for you missing them.  Fun times all around.  Please address all of my comments
from there on this CL :P

https://chromiumcodereview.appspot.com/1288903002/#ps40001

[Lalit Maganti, 2015/08/26 13:11:56]

Yeah I missed them all because I basically redid the CL from scratch so thought
that most of the comments from the old CL would not be relevant. Clearly that
was a mistake.

Sorry about that. Being careless with review comments is something I have
noticed is a big problem and I'm actively working on being more careful about
these things.

I will put all those cleanups in a separate CL as the would just pollute this
one.

-class ShortcutHelper {
+// ShortcutHelper in Java.
+class ShortcutHelper final {
  public:
   // Registers JNI hooks.
   static bool RegisterShortcutHelper(JNIEnv* env);
@@ -21,9 +20,16 @@ class ShortcutHelper {
   // Adds a shortcut to the launcher using a SkBitmap.
   // Must be called on the IO thread.
   static void AddShortcutInBackgroundWithSkBitmap(const ShortcutInfo& info,
+                                                  const std::string& webapp_id,
                                                   const SkBitmap& icon_bitmap);
+
+  // Add splashscreen icon to the data of the webapp.
+  static void AddSplashscreenIconToWebappData(const std::string& webapp_id,
+                                              const SkBitmap& splash_icon);
+
  private:
-  ShortcutHelper();
+  ShortcutHelper() = delete;
+  ~ShortcutHelper() = delete;
 
   DISALLOW_COPY_AND_ASSIGN(ShortcutHelper);
 };