webapps: initial addition of splash screen icon downloading

chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
index d31737a9f659a011af5a91725ffcb438d7294f87..dc61b0435eea512267b10353d9225743334c7ed1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
@@ -5,10 +5,12 @@
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Context;
+import android.content.res.Resources;
 import android.graphics.Bitmap;
 
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.annotations.CalledByNative;
+import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ShortcutHelper;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.content_public.browser.WebContents;
@@ -45,8 +47,18 @@ public class AddToHomescreenDialogHelper {
      * @param observer Observer to notify.
      */
     public void initialize(Observer observer) {
+        Resources resources = mAppContext.getResources();
+
+        int splashSizePx = resources.getDimensionPixelSize(R.dimen.webapp_splash_icon_size);

[gone, 2015/08/26 02:01:19]

This logic is duplicated.  Is there anywhere common you can pull it out to?

[Lalit Maganti, 2015/08/26 13:11:56]

The best place would probably be ShortcutHelper but I'm worried it's turning
into a bit a of a dumping ground for this code. At least the refactor I did
earlier makes that a bit more bearable I guess.

I have moved it to ShortcutHelper - if you have a better idea let me know.

+        int iconSizePx = resources.getDimensionPixelSize(R.dimen.app_banner_icon_size);
+        float density = resources.getDisplayMetrics().density;
+
+        int splashIconDp = (int) (splashSizePx / density);
+        int iconDp = (int) (iconSizePx / density);
+
         mObserver = observer;
-        mNativeAddToHomescreenDialogHelper = nativeInitialize(mTab.getWebContents());
+        mNativeAddToHomescreenDialogHelper = nativeInitialize(
+            mTab.getWebContents(), splashIconDp, iconDp);

[gone, 2015/08/26 02:01:19]

nit: indentation is wrong.

[Lalit Maganti, 2015/08/26 13:11:56]

Done.

     }
 
     /**
@@ -97,7 +109,8 @@ public class AddToHomescreenDialogHelper {
                 ApplicationStatus.getApplicationContext(), icon, url, red, green, blue);
     }
 
-    private native long nativeInitialize(WebContents webContents);
+    private native long nativeInitialize(WebContents webContents,
+            int idealSplashIconSizeInDp, int idealIconSizeInDp);

[gone, 2015/08/26 02:01:19]

nit: use consistent naming for these function definitions and the parameters you
pass in above.

[Lalit Maganti, 2015/08/26 13:11:56]

Done.

     private native void nativeAddShortcut(long nativeAddToHomescreenDialogHelper,
             String userRequestedTitle);
     private native void nativeDestroy(long nativeAddToHomescreenDialogHelper);